Skip to content

Add some regression tests #25056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 4, 2015
Merged

Add some regression tests #25056

merged 9 commits into from
May 4, 2015

Conversation

jooert
Copy link
Contributor

@jooert jooert commented May 2, 2015

Add several regression tests and remove some unnecessary FIXMEs.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 4e4e300

Thanks!

@bors
Copy link
Collaborator

bors commented May 3, 2015

⌛ Testing commit 4e4e300 with merge 58c6223...

@bors
Copy link
Collaborator

bors commented May 3, 2015

💔 Test failed - auto-mac-32-opt

@jooert
Copy link
Contributor Author

jooert commented May 3, 2015

The failing code is in vec-fixed-length.rs:

if cfg!(target_pointer_width = "64") {
    assert_eq!(size_of::<[u8; (1 << 32)]>(), (1 << 32));
}

It fails because the left shifts will overflow on 32 bit. Perhaps we should replace the if cfg!(...) with a #[cfg(...)] so that this code isn't compiled (and doesn't error) on 32 bit platforms?

@jooert
Copy link
Contributor Author

jooert commented May 4, 2015

Hm, that doesn't work either, because RFC 16 wasn't implemented fully. I have added a quite nasty workaround (introduced a test function whose implementation is different dependent on target_pointer_width).

@alexcrichton retry?

@alexcrichton
Copy link
Member

@bors: r+ e7d052e

@bors
Copy link
Collaborator

bors commented May 4, 2015

⌛ Testing commit e7d052e with merge 9b481f8...

bors added a commit that referenced this pull request May 4, 2015
Add several regression tests and remove some unnecessary FIXMEs.
@bors
Copy link
Collaborator

bors commented May 4, 2015

@bors bors merged commit e7d052e into rust-lang:master May 4, 2015
@jooert jooert deleted the sometests branch May 4, 2015 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants