-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add some regression tests #25056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some regression tests #25056
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
⌛ Testing commit 4e4e300 with merge 58c6223... |
💔 Test failed - auto-mac-32-opt |
The failing code is in vec-fixed-length.rs: if cfg!(target_pointer_width = "64") {
assert_eq!(size_of::<[u8; (1 << 32)]>(), (1 << 32));
} It fails because the left shifts will overflow on 32 bit. Perhaps we should replace the |
Hm, that doesn't work either, because RFC 16 wasn't implemented fully. I have added a quite nasty workaround (introduced a test function whose implementation is different dependent on @alexcrichton retry? |
Add several regression tests and remove some unnecessary FIXMEs.
Add several regression tests and remove some unnecessary FIXMEs.